On Sun, 10 Mar 2013 08:22:47 +0000 James Bottomley <jbottomley@xxxxxxxxxxxxx> wrote:
> [missing SCSI cc added]
> On Sun, 2013-03-10 at 17:09 +0900, Akinobu Mita wrote:
> > This fixes the wrong position of the comment introduced by
> > scsi-rename-random32-to-prandom_u32.patch in the -mm tree.
> >
> > Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> > Cc: "James E.J. Bottomley" <JBottomley@xxxxxxxxxxxxx>
> > Cc: Andrew Vasquez <andrew.vasquez@xxxxxxxxxx>
> > ---
> > drivers/scsi/qla2xxx/qla_attr.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c
> > index 04bf7b8..e44d47e 100644
> > --- a/drivers/scsi/qla2xxx/qla_attr.c
> > +++ b/drivers/scsi/qla2xxx/qla_attr.c
> > @@ -1939,13 +1939,13 @@ qla24xx_vport_delete(struct fc_vport *fc_vport)
> > }
> >
> > /* No pending activities shall be there on the vha now */
> > - if (ql2xextended_error_logging & ql_dbg_user)
> > - msleep(prandom_u32() % 10);
> > + if (ql2xextended_error_logging & ql_dbg_user) {
> > /*
> > * Just to see if something falls on the net we have placed
> > * below
> > */
> > -
> > + msleep(prandom_u32() % 10);
> > + }
>
> I don't git a toss if it's random or prandom: Andrew: get rid of it; we
> do not sleep in kernel for random intervals whatever the provocation ...
> if this is supposed to be a warning or error condition then print
> something.
That msleep was added by
commit feafb7b1714cf599a6d0fed45801ab3f66046cbd
Author: Arun Easi <arun.easi@xxxxxxxxxx>
AuthorDate: Fri Sep 3 14:57:00 2010 -0700
Commit: James Bottomley <James.Bottomley@xxxxxxx>
CommitDate: Sun Sep 5 15:13:12 2010 -0300
[SCSI] qla2xxx: Fix vport delete issues
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
