On Thu, 2013-03-07 at 20:14 -0800, Roland Dreier wrote: > On Thu, Mar 7, 2013 at 5:45 PM, Nicholas A. Bellinger > <nab@xxxxxxxxxxxxxxx> wrote: > > +EXPORT_SYMBOL(iscsit_get_transport); > > It's not clear to me why this needs to be exported. Who would use it > outside the core iscsi target module? Oversight on my part. Dropping the unnecessary export of iscsit_get_transport() and iscsit_put_transport() from iscsi-target code now.. Also, realistically, I don't expect module code beyond ib_isert.ko to ever use the definitions in include/target/iscsi/ either. Or and I discussed this point in the last status call, and given what the initiator did originally (eg: export iscsi_transport) he asked to keep it under drivers/infiniband/ulp/isert/ with the extra include bits. I'd have a slight preference to move iser-target code under drivers/target/iscsi/, and not put anything into include/target/iscsi/ if there won't be another module that uses it.. Do you have a preference here..? --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
