Re: [PATCH] aic7xxx: Remove redundant NULL check before kfree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2013-03-06 at 00:56 +0530, Syam Sidhardhan wrote:
> kfree on NULL pointer is a no-op.

This is true, but what's the saving?  kfree() has an identical check,
but by the time you get to it, the result of this one is cached, so it's
something like < 1 instruction cycle saving (because the instruction
will be pipelined).

If the maintainers of particular drivers want to integrate this, that's
OK, but I'd rather not do pure code churn on the older drivers.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux