On Tue, Mar 5, 2013 at 10:08 AM, James Bottomley
<James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:
> On Tue, 2013-03-05 at 12:42 +0900, Jingoo Han wrote:
>> This patch uses module_platform_driver_probe() macro which makes
>> the code smaller and simpler.
>
> These drivers are in deep maintenance mode. Unless you can find someone
> to actually test the changes, we err on the side of not touching the
> code except for serious bugs.
>
> I've cc'd Geert because he may actually have one of these things.
I don't have one, but there are A3000s in active use as Debian build daemons.
>> Signed-off-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
>> ---
>> drivers/scsi/a3000.c | 13 +------------
>> 1 files changed, 1 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/scsi/a3000.c b/drivers/scsi/a3000.c
>> index e29fe0e..519832d 100644
>> --- a/drivers/scsi/a3000.c
>> +++ b/drivers/scsi/a3000.c
>> @@ -279,18 +279,7 @@ static struct platform_driver
>> amiga_a3000_scsi_driver = {
>> },
>> };
>>
>> -static int __init amiga_a3000_scsi_init(void)
>> -{
>> - return platform_driver_probe(&amiga_a3000_scsi_driver,
>> - amiga_a3000_scsi_probe);
>> -}
>> -module_init(amiga_a3000_scsi_init);
>> -
>> -static void __exit amiga_a3000_scsi_exit(void)
>> -{
>> - platform_driver_unregister(&amiga_a3000_scsi_driver);
>> -}
>> -module_exit(amiga_a3000_scsi_exit);
>> +module_platform_driver_probe(amiga_a3000_scsi_driver,
>> amiga_a3000_scsi_probe);
>>
>> MODULE_DESCRIPTION("Amiga 3000 built-in SCSI");
>> MODULE_LICENSE("GPL");
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
