On Mon, 2013-02-25 at 21:44 +0530, Vinayak Holikatti wrote: > This patch separates PCI code from ufshcd.c and makes it as a > core driver module and adds a new file ufshcd-pci.c as PCI glue > driver. You rebased this, but didn't compile it: CC [M] drivers/scsi/ufs/ufshcd-pci.o drivers/scsi/ufs/ufshcd-pci.c:131:1: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘ufshcd_pci_probe’ drivers/scsi/ufs/ufshcd-pci.c:196:11: error: ‘ufshcd_pci_probe’ undeclared here (not in a function) drivers/scsi/ufs/ufshcd-pci.c:197:2: error: implicit declaration of function ‘__devexit_p’ [-Werror=implicit-function-declaration] drivers/scsi/ufs/ufshcd-pci.c:197:2: error: initializer element is not constant drivers/scsi/ufs/ufshcd-pci.c:197:2: error: (near initialization for ‘ufshcd_pci_driver.remove’) drivers/scsi/ufs/ufshcd-pci.c:110:12: warning: ‘ufshcd_set_dma_mask’ defined but not used [-Wunused-function] cc1: some warnings being treated as errors make[3]: *** [drivers/scsi/ufs/ufshcd-pci.o] Error 1 That's because of a stray __devinit and devexit_p() which no-longer exist in the kernel. I've fixed this up. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
