That was a response to Sergei's message (which is properly tracked on the lists). On Thu, Jan 31, 2013 at 2:27 PM, James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote: > On Thu, 2013-01-31 at 14:00 -0800, dbasehore . wrote: >> (Resending as plain text so the message is tracked on vger) >> >> Hi, thanks for reading through my patch. >> >> With regards to SCSI_SENSE_BUFFERSIZE, I'm following the precedent of >> scsi_execute_req found in drivers/scsi/scsi_lib.c > > I have no context for this: I don't recall making any comment on sense > buffers; what are you replying to? > > James > >> It seems that it is used by the scsi_normalize_sense function which I >> call in sd_resume_async. I just input SCSI_SENSE_BUFFERSIZE directly >> there though. I didn't know if anything would change its behavior on a >> lower level if I made sense_len = SCSI_SENSE_BUFFERSIZE, so I just >> went with what was already done. >> >> I'll make sure the semantic fixes go into the final patch. >> >> Also, I forgot to mention one possible problem earlier. I understand >> that some hard drives have a command buffer that can be executed by >> the hard drive in an order it determines. Does anyone know of a >> potential problem if the following happens? >> >> -resume finishes (hard drive not started yet) >> -read/write sent to disk, inserted before start command >> >> Could this happen? If so, could it cause any problems? >> >> I've tested the possibility of a program trying to read/write from the >> disk before it has started, and the read/write blocks until the disk >> has actually been spun up. I don't know if there are specific hard >> drives where this could be a problem though. >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
