On Wed, Dec 26, 2012 at 1:33 PM, Ben Hutchings <ben@xxxxxxxxxxxxxxx> wrote:
>> if (!(cmd->cmd_flags & ICF_OOO_CMDSN) && !cmd->immediate_cmd &&
>> - (cmd->cmd_sn >= conn->sess->exp_cmd_sn)) {
>> + iscsi_sna_gte(cmd->stat_sn, conn->sess->exp_cmd_sn)) {
>> list_del(&cmd->i_conn_node);
>> spin_unlock_bh(&conn->cmd_lock);
>> iscsit_free_cmd(cmd);
> [...]
>
> This changes cmd->cmd_sn to cmd->stat_sn, but the commit message only
> describes fixes to wrap-around. Is that another fix or a bug?
Great catch, thanks! This is indeed a bug introduced by the patch.
I'll send out a fix; I guess you could roll it up into this patch, but
I'm not sure any of this stuff is worth getting into 3.2.
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
