Re: [PATCH 6/7] ipr: Implement block iopoll

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2012-11-26 at 09:55 -0600, wenxiong@xxxxxxxxxxxxxxxxxx wrote:
> +static ssize_t ipr_store_iopoll_weight(struct device *dev,
> +                                       struct device_attribute *attr,
> +                                       const char *buf, size_t count)
> +{
> +       struct Scsi_Host *shost = class_to_shost(dev);
> +       struct ipr_ioa_cfg *ioa_cfg = (struct ipr_ioa_cfg
> *)shost->hostdata;
> +       u32 user_iopoll_weight;
> +       unsigned long lock_flags = 0;
> +       int i;
> +
> +       if (!ioa_cfg->sis64) {
> +               dev_info(&ioa_cfg->pdev->dev, "blk-iopoll not
> supported on this adapter\n");
> +               return -EINVAL;
> +       }
> +       user_iopoll_weight = simple_strtoul(buf, NULL, 10);

Checkpatch should have told you not to do this:

WARNING: simple_strtoul is obsolete, use kstrtoul instead
#89: FILE: drivers/scsi/ipr.c:3612:
+       user_iopoll_weight = simple_strtoul(buf, NULL, 10);

Could you please resend with the corrected primitive.

Thanks,

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux