Re: [PATCH] [SCSI] scsi_debug: fix deadlock on module unload, also complete queued commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12-12-13 04:00 AM, Ewan D. Milne wrote:
From: "Ewan D. Milne" <emilne@xxxxxxxxxx>

The module unload path in scsi_debug was calling del_timer_sync() with the
queued_arr_lock held.  The timer_intr_handler() function also takes this lock,
so if it executes as the timer is being removed, the kernel would deadlock.

Also changed to complete all queued commands if scsi_debug is unloaded instead
of discarding them, because the requests would eventually timeout after the
module was gone.

Signed-off-by: Ewan D. Milne <emilne@xxxxxxxxxx>

Acked-by: Douglas Gilbert <dgilbert@xxxxxxxxxxxx>


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux