Hello, On Wed, Nov 28, 2012 at 01:48:59PM +0100, Bart Van Assche wrote: > Now that all scsi_request_fn() callers hold a reference on the > SCSI device that function is invoked on and since > blk_cleanup_queue() waits until scsi_request_fn() has finished > it is safe to remove the get_device() / put_device() pair from > scsi_request_fn(). > > Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx> > Acked-by: Tejun Heo <tj@xxxxxxxxxx> > Cc: James Bottomley <JBottomley@xxxxxxxxxxxxx> > Cc: Mike Christie <michaelc@xxxxxxxxxxx> > Cc: Jens Axboe <axboe@xxxxxxxxx> Acked-by: Tejun Heo <tj@xxxxxxxxxx> with one nit. > @@ -1643,11 +1641,7 @@ out_delay: > if (sdev->device_busy == 0) > blk_delay_queue(q, SCSI_QUEUE_DELAY); > out: > - /* must be careful here...if we trigger the ->remove() function > - * we cannot be holding the q lock */ > - spin_unlock_irq(q->queue_lock); > - put_device(&sdev->sdev_gendev); > - spin_lock_irq(q->queue_lock); > + ; There's one "goto out" at the end of the usual control flow. Please just return from there. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
