mv_chips.h * Copyright 2007 Red Hat, Inc. * Copyright 2008 Marvell. <kewei@xxxxxxxxxxx> * This file is licensed under GPLv2. OK, but someone didn't copy right. #define mw32(reg, val) writel((val), regs + reg) No "caller" will ever pass a WTF expression in reg, only in val. Ever. #define iow32(reg, val) outl(val, (unsigned long)(regs + reg)) Obviously someone "calls" that macro. (Without a WTF reg of course.) #define iow16(reg, val) outw((unsigned long)(val, regs + reg)) #define iow8(reg, val) outb((unsigned long)(val, regs + reg)) Luckily no one "calls" those macros. And no one heard my WTF expression when I read them. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html