On 11/18/2012 11:01 PM, Tejun Heo wrote: > On Tue, Nov 13, 2012 at 08:49:24PM +0800, Aaron Lu wrote: >> On Mon, Nov 12, 2012 at 10:57:10AM -0800, Tejun Heo wrote: >>> On Fri, Nov 09, 2012 at 02:51:57PM +0800, Aaron Lu wrote: >>>> The atapi_eh_tur and atapi_eh_request_sense can be reused by ZPODD >>>> code, so separate them out to a file named libata-atapi.c, and the >>>> Makefile is modified accordingly. No functional changes should result >>>> from this commit. >>> >>> Why is this change necessary? This doesn't seem to help anything to >>> me. >> >> Function zpready introduced in patch 6 used these 2 functions to see if >> an ODD is in a zero power ready state. > > And why zpready can't use the functions if they're in a different file? Oh, sure, they can be used. My thought is that, the 2 functions are for ATAPI and can be used by libata-eh, libata-zpodd and maybe others in the future, so it deserves a separate place. But if this is regarded as unnecessary, I will drop this patch. Thanks, Aaron -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
