Re: [PATCH v2 17/19] be2iscsi: Fix for MBX timeout issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2012-10-24 at 01:45 -0500, Mike Christie wrote:
> On 10/19/2012 06:15 PM, John Soni Jose wrote:
> > @@ -763,26 +750,14 @@ static int beiscsi_get_port_speed(struct Scsi_Host *shost)
> >  			    "BS_%d : Getting Port Speed Failed\n");
> >  
> >  		 return -EBUSY;
> > -	 } else
> > -		wait_event_interruptible(phba->ctrl.mcc_wait[tag],
> > -				phba->ctrl.mcc_numtag[tag]);
> > -
> > -	wrb_num = (phba->ctrl.mcc_numtag[tag] & 0x00FF0000) >> 16;
> > -	extd_status = (phba->ctrl.mcc_numtag[tag] & 0x0000FF00) >> 8;
> > -	status = phba->ctrl.mcc_numtag[tag] & 0x000000FF;
> > -
> > -	if (status || extd_status) {
> > +	 }
> > +	rc = beiscsi_mccq_compl(phba, tag, &wrb, NULL);
> > +	if (rc) {
> >  		beiscsi_log(phba, KERN_ERR,
> 
> There was some small whitespace issues in this patch. Maybe James will
> fix it up when it is merged. I do not know why checkpatch.pl and git did
> not warn about them.

I fixed it up.  I cc'd the checkpatch.pl maintainer.  No idea why it
failed to spot the extra space at line 465 in the patch.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux