Hello, Bart. On Tue, Oct 23, 2012 at 02:11:29PM +0200, Bart Van Assche wrote: > >__blk_run_queue_uncond() is a cold path and I don't think adding a > >test there matters but I think it would be better if we avoid an extra > >branch if possible for __blk_run_queue(). Can't we merge > >blk_queue_stopped/dead() testing? > > How about declaring the function __blk_run_queue_uncond() inline ? > That should allow the compiler to combine the two tests into a > single test. Let's leave it as-is for now. Given the later patches, I no longer think it would be better to merge the testings. Thanks! -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html