On Mon, 2012-09-24 at 15:14 +0200, Bart Van Assche wrote: > Avoid that the sdev reference count can drop to zero before > the queue is run by scsi_run_queue(). Also avoid that the sdev > reference count can drop to zero in the same function by invoking > __blk_run_queue(). [...] if (scsi_device_set_state(sdev, SDEV_CANCEL) != 0) > @@ -977,6 +978,10 @@ void __scsi_remove_device(struct scsi_device *sdev) > blk_cleanup_queue(sdev->request_queue); > cancel_work_sync(&sdev->requeue_work); > > + spin_lock_irqsave(shost->host_lock, flags); > + list_del(&sdev->starved_entry); > + spin_unlock_irqrestore(shost->host_lock, flags); > + This hunk doesn't make much sense. It seems to be orthogonal to the problem listed in the changelog and this action is done on last put anyway. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
