Il 01/10/2012 15:18, Richard W.M. Jones ha scritto: > On Mon, Oct 01, 2012 at 03:13:01PM +0200, Paolo Bonzini wrote: >> Il 20/08/2012 16:05, Paolo Bonzini ha scritto: >>> Il 20/08/2012 16:04, Richard W.M. Jones ha scritto: >>>> From: "Richard W.M. Jones" <rjones@xxxxxxxxxx> >>>> >>>> The sg struct is used without being initialized. >>>> >>>> https://bugzilla.redhat.com/show_bug.cgi?id=847548 >>>> >>>> Signed-off-by: Richard W.M. Jones <rjones@xxxxxxxxxx> >>>> --- >>>> drivers/scsi/virtio_scsi.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c >>>> index c7030fb..8a66f83 100644 >>>> --- a/drivers/scsi/virtio_scsi.c >>>> +++ b/drivers/scsi/virtio_scsi.c >>>> @@ -219,7 +219,7 @@ static int virtscsi_kick_event(struct virtio_scsi *vscsi, >>>> struct scatterlist sg; >>>> unsigned long flags; >>>> >>>> - sg_set_buf(&sg, &event_node->event, sizeof(struct virtio_scsi_event)); >>>> + sg_init_one(&sg, &event_node->event, sizeof(struct virtio_scsi_event)); >>>> >>>> spin_lock_irqsave(&vscsi->event_vq.vq_lock, flags); >>>> >>>> >>> >>> Acked-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> >> >> Ping, is this patch going into 3.7? > > I was a bit surprised to see this wasn't upstream since it's vital for > using virtio-scsi reliably (as well as being a one line fix for a > blatant bug). Indeed I enclosed it in a submission named "[PATCH for 3.6] urgent virtio-scsi fixes" (http://permalink.gmane.org/gmane.linux.kernel/1350337)... Paolo -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
