Re: [PATCH][SCSI] mpt3sas: Paer 1 of MPI API headers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



<sreekanth.reddy@xxxxxxx> writes:

> This patch contains MPI API headers
> This patch is part 1 of MPI API headers.
> Signed-off-by: Sreekanth Reddy <Sreekanth.Reddy@xxxxxxx>
> Reviewed-by: Nagalakshmi Nandigama <Nagalakshmi.Nandigama@xxxxxxx>
> ---
>
>
> diff --git a/drivers/scsi/mpt3sas/mpi/mpi2.h b/drivers/scsi/mpt3sas/mpi/mpi2.h
> new file mode 100644
> index 0000000..03317ff
> --- /dev/null
> +++ b/drivers/scsi/mpt3sas/mpi/mpi2.h
> @@ -0,0 +1,1164 @@

Why can't this and the other headers be shared between the mpt2sas and
mpt3sas drivers?  Looks like you are duplicating a lot of code already
present in drivers/scsi/mpt2sas.  Why?  That's a recipe for maintenance
hell...

And it makes this submission impossible to review.


Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux