Hello, Bart. On Sun, Sep 23, 2012 at 06:20:13PM +0200, Bart Van Assche wrote: > Some request_fn implementations, e.g. scsi_request_fn(), unlock > the queue lock. Make sure that blk_cleanup_queue() waits until all > active request_fn invocations have finished. This fixes a potential > use-after-free at the end of scsi_request_fn(). Also, make sure that > the block layer doesn't invoke request_fn after blk_cleanup_queue() > finished. I think the patch is correct but would prefer if the two changes - request_fn_active and QUEUE_DEAD - are put into separate patches with more detailed explanation what they're protecting how. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html