On Fri, 2012-09-21 at 13:57 +0800, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> > > In case of error, the function target_fabric_configfs_init() returns > ERR_PTR() not NULL pointer. The NULL test in the return value check > should be replaced with IS_ERR(). > > dpatch engine is used to auto generated this patch. > (https://github.com/weiyj/dpatch) > > Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> > --- > drivers/target/sbp/sbp_target.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c > index 39ddba5..773303e 100644 > --- a/drivers/target/sbp/sbp_target.c > +++ b/drivers/target/sbp/sbp_target.c > @@ -2556,9 +2556,9 @@ static int sbp_register_configfs(void) > int ret; > > fabric = target_fabric_configfs_init(THIS_MODULE, "sbp"); > - if (!fabric) { > + if (IS_ERR(fabric)) { > pr_err("target_fabric_configfs_init() failed\n"); > - return -ENOMEM; > + return PTR_ERR(fabric); > } > > fabric->tf_ops = sbp_ops; > > Good catch. Applied to target-pending/for-next for the v3.7-rc1 target-updates PULL. Thanks Wei ! -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
