On Aug 20, 2012, at 8:28 PM, Ying Xue <ying.xue@xxxxxxxxxxxxx> wrote:
> Since we have already in BH context when iscsi_sw_tcp_write_space()
> is called, it's unnecessary to disable BH.
Hey,
I do don't think this is right anymore. It looks like it can be called in sock_setsockopt.
>
> Signed-off-by: Ying Xue <ying.xue@xxxxxxxxxxxxx>
> Acked-by: Michael Christie <michaelc@xxxxxxxxxxx>
> ---
> drivers/scsi/iscsi_tcp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
> index 9220861..d763857 100644
> --- a/drivers/scsi/iscsi_tcp.c
> +++ b/drivers/scsi/iscsi_tcp.c
> @@ -194,7 +194,7 @@ static void iscsi_sw_tcp_write_space(struct sock *sk)
> struct iscsi_sw_tcp_conn *tcp_sw_conn;
> void (*old_write_space)(struct sock *);
>
> - read_lock_bh(&sk->sk_callback_lock);
> + read_lock(&sk->sk_callback_lock);
> conn = sk->sk_user_data;
> if (!conn) {
> read_unlock_bh(&sk->sk_callback_lock);
> @@ -204,7 +204,7 @@ static void iscsi_sw_tcp_write_space(struct sock *sk)
> tcp_conn = conn->dd_data;
> tcp_sw_conn = tcp_conn->dd_data;
> old_write_space = tcp_sw_conn->old_write_space;
> - read_unlock_bh(&sk->sk_callback_lock);
> + read_unlock(&sk->sk_callback_lock);
>
> old_write_space(sk);
>
> --
> 1.7.11
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
