Re: [PATCH] qla2xxx: Correct loop_id_map allocation-size and usage.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2012-09-20 at 03:39 -0400, Saurav Kashyap wrote:
> From: Andrew Vasquez <andrew.vasquez@xxxxxxxxxx>
> 
> Original code incorrectly assigned LOOPID_MAP_SIZE to be the
> allocation size in bytes rather than total bit size.
> Additionally corrected code to check for bit-allocation failure
> in qla2x00_find_new_loop_id().
> 
> Signed-off-by: Andrew Vasquez <andrew.vasquez@xxxxxxxxxx>
> Signed-off-by: Saurav Kashyap <saurav.kashyap@xxxxxxxxxx>
> ---
>  drivers/scsi/qla2xxx/qla_def.h  |    2 +-
>  drivers/scsi/qla2xxx/qla_init.c |    4 ++--
>  drivers/scsi/qla2xxx/qla_os.c   |    3 ++-
>  3 files changed, 5 insertions(+), 4 deletions(-)

This is correcting a bug introduced by

commit 07f2a8c179aa81075a161e6d0c522aa1289d994f
Author: Chad Dupuis <chad.dupuis@xxxxxxxxxx>
Date:   Wed Aug 22 14:21:00 2012 -0400

    [SCSI] qla2xxx: Use bitmap to store loop_id's for fcports.

Isn't it?  So rather than introducing a bug and later fixing it, we
should just merge the two, since it's not yet upstream, right?

James


--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux