On 09/07/12 01:20, Tejun Heo wrote: > I think Mike is wondering whether your patch in isolation is enough or > we also need to have DEAD check there too. The proposed patch can't > handle the case where q->request_fn() is invoked after drain is > complete. I'm not really sure whether that can happen tho. Hello Tejun, I'm not sure it would be a good idea to add a blk_queue_dead() check in any of the __blk_run_queue() variants since blk_drain_queue() can invoke __blk_run_queue() to drain the queue. Also, as far as I can see the functions that can insert a request into the queue (blk_insert_cloned_request(), queue_unplugged(), blk_execute_rq_nowait()) all check whether the queue is dead before inserting a request. That should be sufficient to prevent that new requests are queued after QUEUE_FLAG_DEAD has been set. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
