Re: [PATCH 0/12] qla4xxx: Updates for scsi "misc" branch.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Aug 22, 2012, at 6:54 AM, vikas.chaudhary@xxxxxxxxxx wrote:
> Vikas Chaudhary (12):
>      qla4xxx: Update function name from 8xxx to 82xx
>      qla4xxx: Update structure and variable names
>      qla4xxx: Update func name from ql4_ to qla4_
>      qla4xxx: Rename macros from 82XX to 8XXX
>      qla4xxx: Clean-up and optimize macros
>      qla4xxx: Added new functions in isp_ops
>      qla4xxx: Replace all !is_qla8022() with is_qla40XX()
>      qla4xxx: Set IDC version in correct way
>      qla4xxx: Added new function qla4_8xxx_get_minidump
>      qla4xxx: Added support for ISP83XX
>      qla4xxx: Update Copyright header
>      qla4xxx: Update driver version to 5.03.00-k0


Patches look ok overall. There are some minor coding style issues in patch 10.
- do not need a "return" statement at the end of a function that does not return something
- some people do not like a extra newlines like this:

x = something;

if (x == something else)

but I think it would be ok to clean those up later since they are minor.

Reviewed-by: Mike Christie <michaelc@xxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux