On Wed, 2012-09-05 at 14:42 +0800, Wei Yongjun wrote: > From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> > > Using list_move_tail() instead of list_del() + list_add_tail(). > > spatch with a semantic match is used to found this problem. > (http://coccinelle.lip6.fr/) > > Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> > --- > drivers/target/sbp/sbp_target.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/target/sbp/sbp_target.c b/drivers/target/sbp/sbp_target.c > index 39ddba5..e57971f 100644 > --- a/drivers/target/sbp/sbp_target.c > +++ b/drivers/target/sbp/sbp_target.c > @@ -660,8 +660,7 @@ static void session_reconnect_expired(struct sbp_session *sess) > spin_lock_bh(&sess->lock); > list_for_each_entry_safe(login, temp, &sess->login_list, link) { > login->sess = NULL; > - list_del(&login->link); > - list_add_tail(&login->link, &login_list); > + list_move_tail(&login->link, &login_list); > } > spin_unlock_bh(&sess->lock); > > > > -- Applied to target-pending/for-next. Thanks Wei! --nab -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
