Re: [PATCH 2/7] Issue MBX Cmd for login to boot target in crashdump mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/13/2012 05:29 AM, John Soni Jose wrote:
>  When the driver comes up in crashdump mode, it has to explicitly
>  issue command to FW for logging to the boot target. This fix issues
>  MBX Cmd to login to boot target in crashdump mode.
> 
> Signed-off-by: John Soni Jose <sony.john-n@xxxxxxxxxx>
> Signed-off-by: Jayamohan Kallickal <jayamohan.kallickal@xxxxxxxxxx>


Could you fix the whitespace/tabs so they match the rest of the driver?


> + * beiscsi_get_boot_info : Get the boot session info

Driver does "-". I think for proper docbook style for functions we are
supposed to do "() -", but just - is ok for now, until we come alone and
fix them all.


> + * @phba : the device priv structure instance.

No space after phba. Check other places.

> +unsigned int mgmt_reopen_session(struct beiscsi_hba *phba,
> +		unsigned int reopen_type, unsigned int sess_handle)


Need some tabs. Check other places.

> +/**
> +  * be_mgmt_get_boot_shandle : Get the session handle for
> +  *							   boot session.

Not sure what happened with that second line.

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux