On 08/04/12 16:46, Mike Christie wrote: > I think we have to have scsi-ml do a get_device when a sdev is added to > the starved entry and then do a put_device when it is removed (must do > these under the host lock for the starved entry case too). I am not sure > if that is just a hack/papering-over of the problem and there are more > issues like this. That would result in a more complex patch than the patch at the start of this thread, isn't it ? Also, IMHO it would help to document which functions in the scsi-ml are called with an sdev reference and which ones not. That would make the scsi-ml code easier to verify for issues like the one reported at the start of this thread. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html