On Thursday 02 August 2012 11:43:44 James Bottomley wrote: > this should be inside the switch as > > default: > return -EIO; > > and no return statment outside of the switch. OK > Don't you still want to handle BUSY and QUEUE_FULL as -EBUSY? Right at > the moment they'll fall through the default case and return -EIO. True. They should be handled. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html