Hi Vinayak.
> + * ufshcd_pltfrm_remove - remove platform driver routine
> + * @pdev: pointer to platform device handle
> + *
> + * Returns 0 on success, non-zero value on failure
> + */
> +static int __devexit ufshcd_pltfrm_remove(struct platform_device *pdev)
> +{
> + struct resource *mem_res;
> + struct resource *irq_res;
> + resource_size_t mem_size;
> + struct ufs_hba *hba = platform_get_drvdata(pdev);
> +
> + ufshcd_remove(hba);
> + irq_res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> + if (!irq_res)
> + dev_err(&pdev->dev, "ufshcd: IRQ resource not available\n");
> + free_irq(irq_res->start, hba);
Is there no possibility of null pointer dereferencing error ?(irq_res->start)
I think that free_irq should be not called if irq_res is NULL.
> + mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
Looks mem_res is also same with upper case.
Thanks.
> + mem_size = resource_size(mem_res);
> + release_mem_region(mem_res->start, mem_size);
> + platform_set_drvdata(pdev, NULL);
> + return 0;
> +}
> +
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
