Vinayak Holikatti wrote:
> +static int __devinit
> +ufshcd_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> +{
> + struct ufs_hba *hba;
> + void __iomem *mmio_base;
> + int err;
> +
> + err = pci_enable_device(pdev);
> + if (err) {
> + dev_err(&pdev->dev, "pci_enable_device failed\n");
> + goto out_error;
> + }
My question as basically every time at this point: why not use devres, i.e.
pcim_enable_device()? This would make the cleanup and error handling much
easier. See Documentation/driver-model/devres.txt.
> +
> + pci_set_master(pdev);
> +
> +
Duplicate newline.
EikeAttachment:
signature.asc
Description: This is a digitally signed message part.
