On Wed, 2012-07-11 at 19:37 +0100, James Bottomley wrote: > On Fri, 2012-07-06 at 20:15 +0000, Nicholas A. Bellinger wrote: > > From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> > > > > This patch changes virtio-scsi to use a new virtio_driver->scan() callback > > so that scsi_scan_host() can be properly invoked once virtio_dev_probe() has > > set add_status(dev, VIRTIO_CONFIG_S_DRIVER_OK) to signal active virtio-ring > > operation, instead of from within virtscsi_probe(). > > > > This fixes a bug where SCSI LUN scanning for both virtio-scsi-raw and > > virtio-scsi/tcm_vhost setups was happening before VIRTIO_CONFIG_S_DRIVER_OK > > had been set, causing VIRTIO_SCSI_S_BAD_TARGET to occur. This fixes a bug > > with virtio-scsi/tcm_vhost where LUN scan was not detecting LUNs. > > > > Tested with virtio-scsi-raw + virtio-scsi/tcm_vhost w/ IBLOCK on 3.5-rc2 code. > > > > Reviewed-by: Paolo Bonzini <pbonzini@xxxxxxxxxx> > > Cc: Stefan Hajnoczi <stefanha@xxxxxxxxxxxxxxxxxx> > > Cc: Zhi Yong Wu <wuzhy@xxxxxxxxxx> > > Cc: Christoph Hellwig <hch@xxxxxx> > > Cc: Hannes Reinecke <hare@xxxxxxx> > > Cc: <stable@xxxxxxxxxxxxxxx> > > Signed-off-by: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> > > --- > > drivers/scsi/virtio_scsi.c | 15 ++++++++++++--- > > drivers/virtio/virtio.c | 5 ++++- > > include/linux/virtio.h | 1 + > > 3 files changed, 17 insertions(+), 4 deletions(-) > > This doesn't apply: > > patching file drivers/scsi/virtio_scsi.c > Hunk #1 succeeded at 677 (offset 196 lines). > Hunk #2 FAILED at 494. > Hunk #3 succeeded at 736 (offset 198 lines). > 1 out of 3 hunks FAILED -- saving rejects to file > drivers/scsi/virtio_scsi.c.rej > > could you respin against scsi-misc head? > The updated patch is on it's way rebased against scsi.git/misc. Thanks James! -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
