On Thu, 05 Jul 2012 07:52:25 -0700 Robert Love <robert.w.love@xxxxxxxxx> wrote: > strtoul returns an 'unsigned long' so there is no > reason to check if the value is less than zero. > > strtoul already checks for the '-' character deep > in its bowels. It will return an error if the user > has provided a negative value and fcoe_str_to_dev_loss > will return that error to its caller. huh, I never knew that. So if we feed -1 to kstrtoul() it gets treated as an error? That seems a bit surprising. You're sure about that? > This patch fixes the following Coverity reported warning: > > CID 703581 - NO_EFFECT Unsigned compared against 0 - This > less-than-zero comparison of an unsigned value is never true. "*val < 0UL". > drivers/scsi/fcoe/fcoe_sysfs.c:105 > > Signed-off-by: Robert Love <robert.w.love@xxxxxxxxx> > --- > drivers/scsi/fcoe/fcoe_sysfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/scsi/fcoe/fcoe_sysfs.c b/drivers/scsi/fcoe/fcoe_sysfs.c > index 2bc1631..5e75168 100644 > --- a/drivers/scsi/fcoe/fcoe_sysfs.c > +++ b/drivers/scsi/fcoe/fcoe_sysfs.c > @@ -102,7 +102,7 @@ static int fcoe_str_to_dev_loss(const char *buf, unsigned long *val) > int ret; > > ret = kstrtoul(buf, 0, val); > - if (ret || *val < 0) > + if (ret) > return -EINVAL; > /* > * Check for overflow; dev_loss_tmo is u32 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
