On Thu, 2012-07-05 at 04:14 +0000, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> > > The SGL memory allocated during vhost_scsi_map_iov_to_sgl() setup was never > getting freed during tv_cmd completion -> release path. Fix this up by releasing > tv_cmd->tvc_sgl in vhost_scsi_free_cmd() ahead of tv_cmd descriptor free. > > Cc: Stefan Hajnoczi <stefanha@xxxxxxxxxxxxxxxxxx> > Cc: Zhi Yong Wu <wuzhy@xxxxxxxxxx> > Cc: Michael S. Tsirkin <mst@xxxxxxxxxx> > Signed-off-by: Nicholas Bellinger <nab@xxxxxxxxxxxxxxx> > --- > drivers/vhost/tcm_vhost.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/vhost/tcm_vhost.c b/drivers/vhost/tcm_vhost.c > index cd86633..9692153 100644 > --- a/drivers/vhost/tcm_vhost.c > +++ b/drivers/vhost/tcm_vhost.c > @@ -387,6 +387,8 @@ static void vhost_scsi_free_cmd(struct tcm_vhost_cmd *tv_cmd) > u32 i; > for (i = 0; i < tv_cmd->tvc_sgl_count; i++) > put_page(sg_page(&tv_cmd->tvc_sgl[i])); > + > + kfree(tv_cmd->tvc_sgl); > } > > kfree(tv_cmd); Reviewed-by: Zhi Yong Wu <wuzhy@xxxxxxxxxxxxxxxxxx> -- Regards, Zhi Yong Wu -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
