On Wed, 2012-06-27 at 15:29 +0800, Cong Meng wrote: > Fix BLKSECTGET ioctl of sg device caculation mistake. > > Signed-off-by: Cong Meng <mc@xxxxxxxxxxxxxxxxxx> > --- > drivers/scsi/sg.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c > index eacd46b..c424602 100644 > --- a/drivers/scsi/sg.c > +++ b/drivers/scsi/sg.c > @@ -1070,7 +1070,7 @@ sg_ioctl(struct file *filp, unsigned int cmd_in, unsigned long arg) > return -ENODEV; > return scsi_ioctl(sdp->device, cmd_in, p); > case BLKSECTGET: > - return put_user(queue_max_sectors(sdp->device->request_queue) * 512, > + return put_user(queue_max_sectors(sdp->device->request_queue), Really, no. This would break all existing user of the ioctl. Even if you can find a document somewhere that says BLKSECTGET should return sectors instead of bytes, we have to go with the ABI we've been exporting for decades and fix up the document. James -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
