On Fri, 2012-06-22 at 12:46 -0600, Matthew Wilcox wrote:
> On Thu, Jun 21, 2012 at 07:50:02AM +0000, James Bottomley wrote:
> > @@ -22,7 +22,9 @@
> > ccflags-$(GCOV) := -fprofile-arcs -ftest-coverage
> > ccflags-$(GCOV) += -O0
> >
> > +ifdef WARNINGS_BECOME_ERRORS
> > ccflags-y += -Werror
> > +endif
> >
> > obj-$(CONFIG_SCSI_LPFC) := lpfc.o
>
> Why not more simply:
>
> ccflags-$(WARNINGS_BECOME_ERRORS) += -Werror
Because it's not a config option, it's a makefile option. If we go with
what you propose, the format of make has to be
make WARNINGS_BECOME_ERRORS=y
which is a bit non intuitive.
> > N?????r??y????b?X????v?^?)??{.n?+????{???"?{ay? ?????,j??f???h???z? ?w??? ???j:+v???w?j?m????????zZ+???????j"??!
>
> That's some nasty line noise on your modem there, James.
No, it's because majordomo has some issue doing base64.
James
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
