On 06/21/12 01:56, Greg KH wrote: > On Tue, Jun 19, 2012 at 09:54:49AM +0200, Gerd Hoffmann wrote: >> This reverts commit ceb3f91fd53c9fbd7b292fc2754ba4efffeeeedb. >> >> IMO the real bug is assigning status urbs to scsi requests. First there >> is no such link in the non-stream case. Also there isn't nessesarely a >> scsi request in the first place, for example when submitting task >> management requests. >> >> This patch just papers over the real bug and introduces different status >> urb handling in the stream/non-stream case for no good reason. >> >> Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxxxxx> >> --- >> drivers/usb/storage/uas.c | 70 ++++++-------------------------------------- >> 1 files changed, 10 insertions(+), 60 deletions(-) > > Same here, should this also be reverted in 3.4-stable? Well, even though the reverted patch is clumsy and takes the wrong direction, it actually does the job and fixes the issue at hand. When reverting in stable patch #3 of this series (which fixes the issue in a better way) must be cherry-picked into stable too, otherwise we'll get a regression. I'd tend to not revert this one in stable though. cheers, Gerd -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
