On Fri 15-06-12 10:14:12, Paolo Bonzini wrote: > Il 02/05/2012 12:10, Jan Kara ha scritto: > > Sometimes, warnings about ioctls to partition happen often enough that they > > form majority of the warnings in the kernel log and users complain. In some > > cases warnings are about ioctls such as SG_IO so it's not good to get rid of > > the warnings completely as they can ease debugging of userspace problems > > when ioctl is refused. > > > > Since I have seen warnings from lots of commands, including some proprietary > > userspace applications, I don't think disallowing the ioctls for processes > > with CAP_SYS_RAWIO will happen in the near future if ever. So lets just > > stop warning for processes with CAP_SYS_RAWIO for which ioctl is allowed. > > > > CC: Paolo Bonzini <pbonzini@xxxxxxxxxx> > > CC: Jens Axboe <axboe@xxxxxxxxx> > > CC: James Bottomley <JBottomley@xxxxxxxxxxxxx> > > CC: linux-scsi@xxxxxxxxxxxxxxx > > Signed-off-by: Jan Kara <jack@xxxxxxx> > > --- > > block/scsi_ioctl.c | 5 ++++- > > 1 files changed, 4 insertions(+), 1 deletions(-) > > > > diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c > > index 260fa80..9a87daa 100644 > > --- a/block/scsi_ioctl.c > > +++ b/block/scsi_ioctl.c > > @@ -721,11 +721,14 @@ int scsi_verify_blk_ioctl(struct block_device *bd, unsigned int cmd) > > break; > > } > > > > + if (capable(CAP_SYS_RAWIO)) > > + return 0; > > + > > /* In particular, rule out all resets and host-specific ioctls. */ > > printk_ratelimited(KERN_WARNING > > "%s: sending ioctl %x to a partition!\n", current->comm, cmd); > > > > - return capable(CAP_SYS_RAWIO) ? 0 : -ENOIOCTLCMD; > > + return -ENOIOCTLCMD; > > } > > EXPORT_SYMBOL(scsi_verify_blk_ioctl); > > > > > > Ping? Good that you bring this up :). I've asked the customer about whether they can find out the particular SG_IO ioctl Veritas issues but never heard back. So will we merge my patch? I remember you gave it reluctant ack once ;). Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
