Re: scsi: lpfc_scsi: Remove unused variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Richard,

Richard Yao wrote:

> This is my first time patch submission. The commit message should
> explain the issue.
>
> commit ba8c7a7a629b736fdc1abceaa3ec49f8820aec08
> Author: Richard Yao <ryao@xxxxxxxxxxxxxxxxx>
> Date:   Thu Jun 7 01:44:31 2012 -0400
>
>     scsi: lpfc_scsi: Remove unused variables
>
>     Kernels built with CONFIG_SCSI_LPFC fail to compile due to the use of
>     -Werror=unused-variable. We solve that by removing some unused
>     variables.

Wouldn't a saner fix be to stop using -Werror=unused-variable, or am I
missing something subtle?

(Since v3.4-rc1~6^2~48 the makefile seems to use plain -Werror, which
seems even worse, since it means any random compiler bug that triggers
a new warning will break the build.)

Thanks and hope that helps,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux