On 06/06/12 13:43, Mike Christie wrote: > What if we moved the requeue work struct to the request queue, then have > blk_cleanup_queue or blk_drain_queue call cancel_work_sync before the > queue is freed. That way that code could make sure the queue and work is > flushed and drained, and it can make sure it is flushed and drained > before freeing the queue? Sounds like a good idea to me. However, personally I'd prefer with this patch set to focus on fixing bugs and to leave such restructuring for a subsequent patch. Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html