> Looking at this patch which removes tcm_qla2xxx_setup_nacl_from_rport() > usage during explicit tcm_qla2xxx_make_nodeacl() creation, how does an > explicit NodeACL get picked up in tcm_qla2xxx_check_initiator_node_acl() > now with this change ? > > AFAICT this patch makes every new initiator login attempt result in a > demo-mode se_node_acl being generated with virtual LUN=0 access, and > ignores explicit se_node_acl + MappedLUNs groups + links to TPG_LUN in > individual ../target/qla2xxx/$TARGET_WWPN/tpgt_1/acls/$INITIATOR_WWPN/ > > Is there something else that I'm missing here..? [Reply to all this time] We still insert the nacl into the tpg->acl_node_list so we'll find it when we do the check when the session actually shows up. Inserting the nacl into the btree doesn't do anything, since it would have no session pointer and so tcm_qla2xxx_find_sess_by_s_id() will return NULL whether or not we insert the nacl in tcm_qla2xxx_setup_nacl_from_rport(). (And that's the only place that does a btree lookup) - R. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
