On Wed, 2012-05-30 at 01:22 -0400, David Dillow wrote: > On Mon, 2012-05-21 at 17:49 +0200, Bernd Schubert wrote: > > David, below is a first version to convert SRP_RQ_SHIFT into a new > > module option "srp_rq_size". I already tested it, but I also need to > > re-read it myself. > > > > Author: Bernd Schubert <bernd.schubert@xxxxxxxxxxxxxxxxxx> > > Date: Mon May 21 10:25:01 2012 +0200 > > > > infiniband/srp: convert SRP_RQ_SHIFT into a module parameter > > > > When SRP_RQ_SHIFT is a fix parameter the optimal value is unclear. > > The current value of 6 might be too small for several storage systems > > and larger values might take too much memory for other systems. > > So make it a parameter and let the admin decide. > > This shouldn't be a module parameter; if at all possible, all new > parameters should be specified on a per-target basis, with reasonable > defaults. srp_rq_size isn't the right ... name. "queue_depth" or "max_cmd" or "can_queue" would be better. -- Dave Dillow National Center for Computational Science Oak Ridge National Laboratory (865) 241-6602 office -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
