On Thu, 17 May 2012 14:24:25 -0700, Nicholas A. Bellinger wrote: > > Yes, I think it should be fine to move the loop_id and by fc_id lookup > removal after the vha->hw->tgt.tgt_ops->clear_nacl_from_fcport_map() > call within the call to qlt_unreg_sess() w/ hardware_lock held.. Just in case it wasn't clear from my other mail: no, that will not be fine. Once the refcount drops to zero it must be impossible to hold or obtain any new references. My patch didn't completely plug this hole and neither does your proposal. If that means the fast path just got slower: tough luck! Anyone can write fast incorrect code. If the only way to write correct code is to be slow, we shall be slow. Jörn -- Doubt is not a pleasant condition, but certainty is an absurd one. -- Voltaire -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
