Hi Jack, Thanks for the inputs. Will update the patch accordingly and send it. Thanks Sakthivel K -----Original Message----- From: Jack Wang [mailto:jack_wang@xxxxxxxxx] Sent: Thursday, May 17, 2012 7:45 AM To: Sakthivel Saravanan Kamal Raju; linux-scsi@xxxxxxxxxxxxxxx; jejb@xxxxxxxxxx Cc: lindar_liu@xxxxxxxxx; Anand Kumar S - ERS, HCL Tech Subject: RE [PATCH] [SCSI] pm8001: Added support for 8008, 8009, 8018, 8019 controllers Hi Sakthivel K, Please generate patch against for next branch in URL: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git In your new file most function are same with pm8001 please try to reuse that, not just only change function name or structure name. Please separate this big patch into different patches,that will more reviewable. Thanks Jack ::DISCLAIMER:: ----------------------------------------------------------------------------------------------------------------------- The contents of this e-mail and any attachment(s) are confidential and intended for the named recipient(s) only. E-mail transmission is not guaranteed to be secure or error-free as information could be intercepted, corrupted, lost, destroyed, arrive late or incomplete, or may contain viruses in transmission. The e mail and its contents (with or without referred errors) shall therefore not attach any liability on the originator or HCL or its affiliates. Views or opinions, if any, presented in this email are solely those of the author and may not necessarily reflect the views or opinions of HCL or its affiliates. Any form of reproduction, dissemination, copying, disclosure, modification, distribution and / or publication of this message without the prior written consent of authorized representative of HCL is strictly prohibited. If you have received this email in error please delete it and notify the sender immediately. Before opening any email and/or attachments, please check them for viruses and other defects. ----------------------------------------------------------------------------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html