RE: [PATCH] pm8001: support HDA (flashless) mode (take 3)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi James,

No see this patch going into your tree yet, could you consider to include
this patch into your tree for mainline.

Jack

> - Take 3 actually moved the file references to
> /lib/firmware/pm8001/*img.bin :-)
> - I have contacted PMC, eventually driven to marketing last year, after a
few
> conference calls, crickets (they said they would get back to me) after
they
> understood we wanted these files to be placed on the Linux Firmware
Repository.
> We (Xyratex) were willing to act as PMC's agent for deployment; their
concern
> was getting technical support requests regarding the Firmware directly
from
> the un-washed Customers rather than through the OEMs deploying the chips
on
> their platforms. I countered with a suggestion of a carefully worded
License
> File in association with the images. I will 'ping' them and see if we can
> escalate this today.
> 
> -- Mark
> 
> On May 4, 2012, at 2:16 PM, Kamaljit Singh wrote:
> 
> > Mark,
> >
> > My comments are at a technical level only.  For IP issues please
consider
> talking to the PMC Marketing team.
> >
> > To avoid potential conflicts across firmware files of other PMC products
you
> may want to create a driver specific directory under /lib/firmware.
> > Additionally, I noticed that /lib/firmware has company specific
directories.
> So here are some suggestions.
> >
> > #1: /lib/firmware/pmcs/pm8001/*.bin.
> > #2: /lib/firmware/pm8001/*.bin.
> >
> >
> > Thanks,
> >
> > Kamaljit Singh
> >
> > -----Original Message-----
> > From: linux-scsi-owner@xxxxxxxxxxxxxxx
> [mailto:linux-scsi-owner@xxxxxxxxxxxxxxx] On Behalf Of Mark Salyzyn
> > Sent: Friday, May 04, 2012 4:33 AM
> > To: linux-scsi@xxxxxxxxxxxxxxx
> > Cc: Mark Salyzyn; Jack Wang; James Bottomley; lindar_liu; 于爱华;
john_gong
> > Subject: [PATCH] pm8001: support HDA (flashless) mode (take 3)
> >
> > Third time IS the charm :-)
> >
> > The pm8001 can be delivered as a standalone product with
flash-programmed
> > firmware images, or without the flash present requiring the driver to
upload
> > the images into the chip's RAM and then run. This is called flashless
HDA
> mode.
> >
> > We add support for this firmware upload in the enclosed patch. We try
some
> > basic initialization checks of the Firmware, and if it appears dead, we
make
> > the assumption the adapter must in-fact be halted in this HDA mode. The
> > Firmware images themselves have not been cleared for open-release by
PMC,
> but
> > they are available in OpenSolaris <hint hint>. PMC's rationalization for
not
> > wanting an open-release of the Firmware Images is that they do not want
to
> > take support calls except from paying OEMs (such as Xyratex) that are
> embedding
> > PMC product into the motherboards and thus may have a tested combination
of
> > Firmware and Hardware. Please respect this sentiment. Images are
expected
> in:
> >
> > /lib/firmware/aap1img.bin
> > /lib/firmware/ilaimg.bin
> > /lib/firmware/iopimg.bin
> > /lib/firmware/istrimg.bin
> >
> > using the exact same naming convention as PMC and in OpenSolaris (and
its
> > followon children) for these image files.
> >
> > Take 2 of the patch, added manifests MAIN_HDA_FLAGS_FORCE_HDA and
> > MAIN_HDA_FLAGS_HDA_FW to check against the bit value of .hda_mode_flag
> > if the SEEPROM is forcing HDA flashless mode.
> >
> > Take 3 of the patch, added hot-plug reset operations, dropped some
> > unnecessary but inert duplicated operations and dropped the firmware
> > images down one level into /lib/firmware/pm8001/ directory.
> >
> > Signed-off-by: Mark Salyzyn <mark_salyzyn@xxxxxxxxxxx>
> > Review-by: Jack Wang <jack_wang@xxxxxxxxx>
> > Cc: James Bottomley <JBottomley@xxxxxxxxxxxxx>
> > Cc: lindar_liu@xxxxxxxxx
> > Cc: crystal_yu@xxxxxxxxx
> > Cc: john_gong@xxxxxxxxx
> >
> > drivers/scsi/pm8001/pm8001_hwi.c  |  582
> +++++++++++++++++++++++++++++++++++---
> > drivers/scsi/pm8001/pm8001_hwi.h  |   40 ++
> > drivers/scsi/pm8001/pm8001_init.c |   36 ++
> > drivers/scsi/pm8001/pm8001_sas.h  |    3
> > 4 files changed, 616 insertions(+), 45 deletions(-)
> >
> 
> ______________________________________________________________________
> This email may contain privileged or confidential information, which
should
> only be used for the purpose for which it was sent by Xyratex. No further
rights
> or licenses are granted to use such information. If you are not the
intended
> recipient of this message, please notify the sender by return and delete
it.
> You may not use, copy, disclose or rely on the information contained in
it.
> 
> Internet email is susceptible to data corruption, interception and
> unauthorised amendment for which Xyratex does not accept liability. While
we
> have taken reasonable precautions to ensure that this email is free of
viruses,
> Xyratex does not accept liability for the presence of any computer viruses
in
> this email, nor for any losses caused as a result of viruses.
> 
> Xyratex Technology Limited (03134912), Registered in England & Wales,
> Registered Office, Langstone Road, Havant, Hampshire, PO9 1SA.
> 
> The Xyratex group of companies also includes, Xyratex Ltd, registered in
> Bermuda, Xyratex International Inc, registered in California, Xyratex
> (Malaysia) Sdn Bhd registered in Malaysia, Xyratex Technology (Wuxi) Co
Ltd
> registered in The People's Republic of China and Xyratex Japan Limited
> registered in Japan.
> ______________________________________________________________________
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux