On Tue, 2012-05-15 at 10:35 -0400, Alan Stern wrote: > On Tue, 15 May 2012, Lin Ming wrote: > > > Add a flag REQ_PM to identify the request is PM related. > > As an example, modify scsi code to use this flag. > > There already is such a flag; you don't need to add one. In fact, > there already are _two_ such flags, and it would be best to remove one > of them. In include/linux/blkdev.h: > > REQ_TYPE_PM_SUSPEND, /* suspend request */ > REQ_TYPE_PM_RESUME, /* resume request */ > > Apparently they had been used by the old ide driver, but they don't > seem to be used anywhere now. IDE code still uses both types and they are used for system suspend/resume. See generic_ide_suspend and generic_ide_resume. But we need a flag to check whether it is runtime suspend/resume request. > > Aside from that, this patch seems to be going in the right direction. > > Alan Stern > -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
