re: qla2xxx: Add LLD target-mode infrastructure for >= 24xx series

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Nicholas Bellinger,

This is a semi-automatic email about new static checker warnings.

The patch 2c0532cbbbb5: "qla2xxx: Add LLD target-mode infrastructure 
for >= 24xx series" from May 3, 2012, leads to the following Smatch 
complaint:

drivers/scsi/qla2xxx/qla_target.c:2965 qlt_abort_task()
	 error: we previously assumed 'sess' could be null (see line 2958)

drivers/scsi/qla2xxx/qla_target.c
  2957		sess = ha->tgt.tgt_ops->find_sess_by_loop_id(vha, loop_id);
  2958		if (sess == NULL) {
                    ^^^^^^^^^^^^
New check.

  2959			ql_dbg(ql_dbg_tgt_mgt, vha, 0xf025,
  2960			    "qla_target(%d): task abort for unexisting "
  2961			    "session\n", vha->vp_idx);
  2962			res = qlt_sched_sess_work(ha->tgt.qla_tgt,
  2963			    QLA_TGT_SESS_WORK_ABORT, iocb, sizeof(*iocb));
  2964			if (res != 0)
  2965				sess->tgt->tm_to_unknown = 1;
                                ^^^^^^^^^
New dereference.

  2966	
  2967			return res;

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux