-----Original Message----- From: Mike Christie <michaelc@xxxxxxxxxxx> Date: Fri, 4 May 2012 03:17:36 -0700 To: Admin <vikas.chaudhary@xxxxxxxxxx> Cc: "jbottomley@xxxxxxxxxxxxx" <jbottomley@xxxxxxxxxxxxx>, scsi <linux-scsi@xxxxxxxxxxxxxxx>, Lalit Chandivade <lalit.chandivade@xxxxxxxxxx>, Ravi Anand <ravi.anand@xxxxxxxxxx>, Tej Parkash <tej.parkash@xxxxxxxxxx>, Shyam Sundar <shyam.sundar@xxxxxxxxxx> Subject: Re: [PATCH 5/6] qla4xxx: Capture minidump for ISP82XX on firmware failure >On 05/04/2012 05:00 AM, Vikas Chaudhary wrote: >>> # echo 6 > /sys/class/scsi_host/host7/device/fw_dump > >echo adds a newline by default. If you do echo -n it does not. I tried with 'echo -n' I am still getting garbage data from sysfs attribute. > >Does simple_strtol handle that but kstrol not handle it? Yes, simple_strtol handle this case. Here are logs: May 4 16:01:01 magana kernel: ------------------------------------------ May 4 16:01:01 magana kernel: qla4xxx 0000:18:00.5: Buf = 4./../../host12 <-- garbage data from sysfs attribute May 4 16:01:01 magana kernel: ------------------------------------------ May 4 16:01:01 magana kernel: qla4xxx 0000:18:00.5: simple strtol val = 4 <-- simple_strtol return correct value May 4 16:01:01 magana kernel: qla4xxx 0000:18:00.5: May 4 16:01:01 magana kernel: Error -22 <-- error from kstrol May 4 16:01:01 magana kernel: qla4xxx 0000:18:00.5: Error Converted Val -2129482613 This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
