I had viewed the hot-plug changes as separate (I see now that was a bogus distinction), I will merge them in. Yes, the check_fw_ready is not needed, but was left in as an attempt to not touch the 'good path' for the other modes, I saw it as it could not hurt. I will test without it, and ensure operation in both our upstream code (?) and the kernel.org patch to be 100% sure. I was admittedly paranoid about removing that one. I had been experimenting and thinking about this one ever since Take-2 left the gate and am not yet satisfied. I appreciate the comments, a sign of a deep dive into this one! Thanks! Take-3 will arrive after testing, I will send you a PM preview to confirm ... Sincerely -- Mark Salyzyn On May 2, 2012, at 8:35 PM, Jack Wang wrote: > Hi Mark, > > I found other issue in this patch need to be addressed. when HDA mode is > enable, we need also change the soft reset signature to HDA signature in > pci_remove/suspend/resume function. > > and in pm8001_chip_init, check fw ready is not need for HDA mode. > > > Best regards > > Jack > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
