Re: Problems with sr_get_events

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 17 Apr 2012, Tejun Heo wrote:

> On Tue, Apr 17, 2012 at 11:33:27AM -0400, Alan Stern wrote:
> > > Hmmm... Maybe but we've been sending GET_EVENT without such provision
> > > for very long time now.  I feel reluctant to change something which
> > > seems to work in this area even if that something is technically
> > > wrong.  It's not like cheap USB devices tend to be technically correct
> > > anyway.
> > 
> > All right, then how do you feel about this patch?  It makes minimal
> > changes, to avoid the inefficiency of sending repeated commands that
> > can never work.
> 
> Hmmm... while I don't object to the patch per-se, I'm not sure what
> benefit it brings.  Do you have any specific case where this is
> necessary / beneficial?  What are we gaining by not issuing GET_EVENT?

We save a little bit of time.  It's not necessary; it's just a small 
optimization.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux