Re: [PATCH 1/2] [SCSI] ufs: update Response UPIU length in dword

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2012/4/6 Santosh Y <santoshsy@xxxxxxxxx>:
> UFSHCI spec mentions that Response UPIU Length(RUL)
> field in Transfer Request Descriptor should be in dword.
>
> Query Response UPIU size is variable depending on the data
> to be read/written and the size of a SCSI command Response
> UPIU is fixed.
>
> Currently response_upiu_length is being updated in bytes.
> If a UFS host controller prepares a Query Response UPIU
> with response_upiu_length, it will result in wrong Query
> Response UPIU size corrupting the command descriptor list.
>
> This issue will not affect the current UFSHCD Ver 0.1,
> since Query function support is not yet implemented.
> But this patch also ensures against command descriptor list
> corruption if a UFS controller prepares SCSI Response UPIU
> with response_upiu_length.
>
> Reported-by: KOBAYASHI Yoshitake <yoshitake.kobayashi@xxxxxxxxxxxxx>
> Reviewed-by: Vinayak Holikatti <vinholikatti@xxxxxxxxx>
> Signed-off-by: Santosh Y <santoshsy@xxxxxxxxx>

Hi Santosh.
I also checked it on UFS specification. Looks good to me.
Reviewed-by: Namjae Jeon <linkinjeon@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux