On 04/05/12 21:29, Mike Christie wrote: > Tomas's bug occurs when drivers use scsi_scan_host, use the async scsi > device scanning, and then rmmod the LLD while the scan is still in progress. > > I think a general problem that we might hit similar to Tomas's issue is > when scanning from userspace then rmmoding the driver. Maybe that means > we need a more generic fix? Or, maybe that could be handled by having > scsi_scan() do a try_module_get before scanning. That suggestion certainly makes sense to me. But Tomas' approach has the advantage that it guarantees that scanning will have finished once scsi_remove_hosts() returned and hence has less potential for triggering race conditions than an approach based on try_module_get(). Bart. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
